[JDO-611] GetObjectIdForPersistentInterface - Implementation Class / PICompany / ICompany Mess

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: JDO 2 maintenance release 2 (2.2)
• Fix Version/s: JDO 2 maintenance release 2 update 1 (2.2.1), JDO 3 (3.0)
• Component/s: tck
• Assignee: Michelle Caisse
• Reporter: Ilan Kirsh
• Created: 05/Nov/08 14:08
• Updated: 14/Nov/08 21:54
• Resolved: 14/Nov/08 21:54

Description

I have two issues with this test:

(1)
IMO, PICompany should be written instead of ICompany:

(a)
ICompany icompany = (ICompany)pm.newInstance(PICompany.class);
instead of:
ICompany icompany = (ICompany)pm.newInstance(ICompany.class);

and:

(b)
addTearDownClass(PICompany.class);
instead of:
addTearDownClass(ICompany.class);

ICompany is not persistence capable, so the implementation does not have to handle it.

(2)
I think that the following check is wrong:

if (icompanyOidClass != icompany.getClass())

icompany.getClass() => the physical internal implementation class
icompanyOidClass => the logical interface (PICompany)

Actually and exception should be thrown if (icompanyOidClass == icompany.getClass())