Uploaded image for project: 'JDO'
  1. JDO
  2. JDO-579

Assertions have parameters swapped

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      I noticed that some of the tests recently checked in swap the "expected" and "actual" values, e.g. in Jdoconfig.java,
      public void checkPersistent(String name) {
      assertEquals("Incorrect PMF name", pmf.getName(), name);

      The signature of assertEquals is
      public static void assertEquals(java.lang.String message,
      java.lang.String expected,
      java.lang.String actual)

      I didn't check too far, but these need to be fixed for the benefit of those whose implementation doesn't actually work.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mcaisse Michelle Caisse
            clr Craig L Russell
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment