[JCS-234] Imported packages for OSGi manifest incorrect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jcs-3.1
• Fix Version/s: jcs-3.2
• Assignee: Thomas Vandahl
• Reporter: Chris Lake
• Created: 04/May/23 01:54
• Updated: 18/Sep/23 17:34
• Resolved: 05/May/23 08:24

Description

The Jira ticket JCS-228 attempted to make the imported packages optional in OSGi Manifest.

 

However, it appears that this was done incorrectly. The change was to add:

     <commons.osgi.import>
         javax.servlet.*;resolution=optional,
         org.apache.commons.dbcp2.*;resolution=optional,
         org.apache.http.*;resolution=optional,
         org.apache.logging.log4j.*;resolution=optional
     </commons.osgi.import>

However, there should be a colon between prior to the equals:

     <commons.osgi.import>
         javax.servlet.*;resolution:=optional,
         org.apache.commons.dbcp2.*;resolution:=optional,
         org.apache.http.*;resolution:=optional,
         org.apache.logging.log4j.*;resolution:=optional
     </commons.osgi.import>

Without it, we can see that the import is not considered optional:

But with the colon. it is correct: