[JCS-163] false error message when reusing a cache directory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Bug
• Affects Version/s: jcs-2.0-beta-1
• Fix Version/s: jcs-2.0-beta-2
• Component/s: Indexed Disk Cache, JDBC Disk Cache
• Assignee: Unassigned
• Reporter: Mark Fulton
• Created: 19/May/16 16:05
• Updated: 25/Dec/16 18:35
• Resolved: 07/Aug/16 09:54

Description

JCS logs an ERROR if the disk cache directory already existed:

63   [main] ERROR org.apache.commons.jcs.auxiliary.disk.AbstractDiskCacheAttributes  - Failed to create directory C:\MyCache

This is because AbstractDiskCacheAttributes.setDiskPath(File) uses the result of File.mkdirs() as if it returns true if the directories exist after invocation but this is not the case, it only returns "true if and only if the directory was created, along with all necessary parent directories; false otherwise."

File.exists() (or similar) should be used instead to trigger logging an ERROR or not.