[JCS-139] PropertySetter doesn't set Enum properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jcs-2.0
• Fix Version/s: jcs-2.0-beta-2
• Assignee: Thomas Vandahl
• Reporter: Youngho Cho
• Created: 30/Dec/14 05:14
• Updated: 25/Dec/16 18:35
• Resolved: 06/Jan/15 10:17

Description

I saw following log
2014-12-30 11:42:44,937 [main] WARN org.apache.commons.jcs.utils.config.PropertySetter - Failed to set property eventQueueType to value "POOLED". Conversion to type [class org.apache.commons.jcs.engine.behavior.ICacheEventQueue$QueueType] failed.

Looks like enum doesn't set properly

Here is a patch

Index: PropertySetter.java
===================================================================
— PropertySetter.java (revision 1648479)
+++ PropertySetter.java (working copy)
@@ -263,6 +263,19 @@
return Boolean.FALSE;
}
}
+ else if( type.isEnum() )
+ {
+ try
+

{ + @SuppressWarnings("unchecked") + Class<Enum> cl = (Class<Enum>) Class.forName(type.getName()); + return Enum.valueOf( cl, v ); + }

+ catch(Exception e)
+

{ + e.printStackTrace(); + }

+ }
else if ( File.class.isAssignableFrom( type ) )
{
return new File( v );

Thanks

Youngho