[JCS-114] Test failures under Java 7 caused by different order of tests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: jcs-2.0-beta-1
• Assignee: Thomas Vandahl
• Reporter: Sebb
• Created: 07/Apr/14 09:55
• Updated: 01/Apr/15 14:51
• Resolved: 21/Apr/14 17:16

Description

ON Java 7 under WinXP I get several test failures. These do not occur with Java 6. The failures are:

 org.apache.commons.jcs.access.SystemPropertyUnitTest#testSystemPropertyInValueDelimiter AssertionFailedError
 org.apache.commons.jcs.auxiliary.disk.jdbc.JDBCDiskCachePoolAccessManagerUnitTest#testConfigurePoolAccessAttributes_Simple ComparisonFailure
 org.apache.commons.jcs.engine.memory.lru.LHMLRUMemoryCacheUnitTest#testGetStatsThroughHub AssertionFailedError
 org.apache.commons.jcs.engine.SystemPropertyUsageUnitTest#testSystemPropertyUsage_inactive AssertionFailedError
 org.apache.commons.jcs.engine.SystemPropertyUsageUnitTest#testSystemPropertyUsage AssertionFailedError

AFAICT these failures occur because Java 7 runs tests in a different order from Java 6.

In each case, the test class has 2 tests.

Either the Unit tests are wrong - e.g. the second test relies on something set up by an earlier test, or the second test fails to clear up afterwards so causes a problem when the test order is reversed.

Otherwise there must be a problem in the code under test - e.g. the code caches a value that it should not.

Issue Links

• is related to: JCS-115 JDBCDiskCachePoolAccessManager is thread hostile