[JCS-108] incorrect equivalence judgement in BlockDisk.write(long, byte[])

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: jcs-2.0-beta-1
• Assignee: Thomas Vandahl
• Reporter: Xiong LIU
• Created: 24/Sep/13 10:59
• Updated: 01/Apr/15 14:51
• Resolved: 25/Sep/13 08:15

Description

In the trunk, BlockDisk.write(long, byte[]) is as follows:

private boolean write( long position, byte[] data )
        throws IOException
    {
        ByteBuffer buffer = ByteBuffer.allocate(HEADER_SIZE_BYTES + data.length);
        buffer.putInt(data.length);
        buffer.put(data);
        buffer.flip();
        int written = fc.write(buffer, position);
        fc.force(true);

        return written == data.length;
    }

where the return statement should be:

        return written == data.length + HEADER_SIZE_BYTES;