[JCRVLT-84] Installhook processor should not recursively call itself

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.16
• Fix Version/s: 3.1.18
• Assignee: Tobias Bocanegra
• Reporter: Tobias Bocanegra
• Created: 02/Mar/15 19:52
• Updated: 06/Apr/15 16:36
• Resolved: 02/Mar/15 21:55

Description

If an installhook fails in the prepare phase, the processor internally changes the phase and then re-executes. it would be cleaner if the package installer controls the phases. this also avoids a cast to an impl:

            try {
                hook.getHook().execute(context);
            } catch (PackageException e) {
                // abort processing only for prepare phase
                if (context.getPhase() == InstallContext.Phase.PREPARE) {
                    log.warn("Hook " + hook.name +" threw package exception. Prepare aborted.", e);
153:                    ((InstallContextImpl) context).setPhase(InstallContext.Phase.PREPARE_FAILED);
                    execute(context);
                    return false;
                }
                log.warn("Hook " + hook.name +" threw package exception. Ignored", e);
            } catch (Throwable e) {