[JCRVLT-684] Mixins recovered using stashing set on incorrect node

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.4
• Fix Version/s: 3.7.0
• Component/s: vlt
• Assignee: Julian Reschke
• Reporter: Julian Reschke
• Created: 10/Feb/23 18:00
• Updated: 19/Jul/23 13:22
• Resolved: 14/Feb/23 16:02

Description

This:

https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/NodeStash.java#L215

        // restore mixins
        Property mixinProperty = tmpNode.hasProperty(JcrConstants.JCR_MIXINTYPES + PROTECTED_PROPERTIES_SUFFIX) ? tmpNode.getProperty(JcrConstants.JCR_MIXINTYPES + PROTECTED_PROPERTIES_SUFFIX) : null;
        if (mixinProperty != null) {
            for (Value value : mixinProperty.getValues()) {
                tmpNode.addMixin(value.getString());
            }
        }

looks fishy to me. Shouldn't it be:

        // restore mixins
        Property mixinProperty = tmpNode.hasProperty(JcrConstants.JCR_MIXINTYPES + PROTECTED_PROPERTIES_SUFFIX) ? tmpNode.getProperty(JcrConstants.JCR_MIXINTYPES + PROTECTED_PROPERTIES_SUFFIX) : null;
        if (mixinProperty != null) {
            for (Value value : mixinProperty.getValues()) {
                destNode.addMixin(value.getString());
            }
        }

?

Issue Links

• relates to: JCRVLT-687 restoring mandatory child nodes from stash fails on Jackrabbit classic
• links to: GitHub Pull Request #273