Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
package-maven-plugin-1.2.2, 3.5.6
-
None
Description
There is a unit test for this: "testContainerPackageType", which currently proves that it is working correctly, however, when calling the "done()" method on the validator, it actually produces a validadtion message of type "error".
In our case, this makes the filevault-package-maven-plugin 1.2.2 fail on any sling:OsgiConfig node that we are specifying in our build, in the case of packageType=container.
With filevault-package-maven-plugin 1.1.8 this was working fine.
Failing test case here: https://github.com/henrykuijpers/jackrabbit-filevault/commit/ef4c30ea465a1e0d3099b446bb4d6986e4bf10de
It fails with:
java.lang.AssertionError:
Expected: not a collection containing ValidationMessage with severity ERROR or WARN
but: was <[ValidationMessage [severity=ERROR, message=Package of type 'CONTAINER' is not supposed to contain anything but OSGi bundles/configurations and subpackages!, line=0, column=0, nodePath=/apps/config/someconfigpid, filePath=apps/config/someconfigpid.xml, basePath=]]>
Expected :not a collection containing ValidationMessage with severity ERROR or WARN
Actual :<[ValidationMessage [severity=ERROR, message=Package of type 'CONTAINER' is not supposed to contain anything but OSGi bundles/configurations and subpackages!, line=0, column=0, nodePath=/apps/config/someconfigpid, filePath=apps/config/someconfigpid.xml, basePath=]]>