[JCRVLT-551] Set jcr:uuid to value from package when updating node

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.4
• Component/s: vlt
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 17/Aug/21 15:14
• Updated: 10/Feb/23 18:27
• Resolved: 24/Aug/21 16:54

Description

Currently the code at https://github.com/apache/jackrabbit-filevault/blob/ac74458a0226eb503d96cf2b238cec78b6f36dc2/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L809 does not try to adjust the jcr:uuid property in case a referenceable node is imported from a package which already exists (potentially with a different jcr:uuid) in the repository.

This contradicts the contract from the javadoc https://github.com/apache/jackrabbit-filevault/blob/c612dda36895d379ec57f6d2834158ea513f2967/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L88 and might be problematic if code is relying on the node identifier for looking up nodes.

Issue Links

• breaks: JCRVLT-584 Forcing UUID on packages may break previously installable packages
• is related to: OAK-9546 Node.getReferences() not working for moved referenceable node
• is related to: OAK-9541 ItemExistsException: "Node with the same UUID exists" thrown during SysView import with existing different UUID
• relates to: OAK-685 Enforce referential integrity for referenceable nodes
• relates to: JCRVLT-85 Import behaviour not always correct in case of conflicting node IDs
• relates to: JCRVLT-685 ImportMode REPLACE vs IdConflictPolicy LEGACY vs stashing
• links to: GitHub Pull Request #159