[JCRVLT-547] Distinguish between recoverable and unrecoverable exceptions in intermediate saves

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5.4
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 05/Jul/21 16:46
• Updated: 04/Aug/22 14:23
• Resolved: 19/Jul/21 14:07

Description

Both RepositoryCopier and Importer leverage intermediate save() operations. Those might transiently fail in case they are triggered e.g. before mandatory child nodes have been added. To no defer non-transient exceptions and to not fail too early the intermediate saves should distinguish between those two exception types. Transient exceptions are subclasses of

1. https://docs.adobe.com/content/docs/en/spec/jsr170/javadocs/jcr-2.0/javax/jcr/InvalidItemStateException.html
2. https://docs.adobe.com/content/docs/en/spec/jsr170/javadocs/jcr-2.0/javax/jcr/nodetype/ConstraintViolationException.html

In case of transient exceptions the AutoSave helper class should just trigger a retry, while for non-transient exceptions it makes sense to bail out immediately with an exception.

Issue Links

• breaks: JCRVLT-646 Potential javax.jcr.nodetype.ConstraintViolationException while deserializing extended file aggregates
• is related to: JCRVLT-648 Don't treat javax.jcr.InvalidItemStateException as transient during package import
• relates to: JCRVLT-534 Allow for skipping items that error.
• links to: GitHub Pull Request #158