[JCRVLT-526] PackagePropertiesImpl doesn't support date format with timezone format +-hhmm

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.5.4

Environment

Sling-Starter 12-SNAPSHOT with JDK 11 on MacOS

• Assignee: Konrad Windszus
• Reporter: Hans-Peter Stoerr
• Created: 28/May/21 14:18
• Updated: 05/Oct/21 14:25
• Resolved: 04/Jun/21 14:14

Description

When packages e.g. a creation date with a timezone format +- hhmm or +-hh are entered into the FSPackageRegistry, the date cannot be read by org.apache.jackrabbit.vault.packaging.impl.PackagePropertiesImpl.getCreated() : it returns null since it internally uses org.apache.jackrabbit.util.ISO8601.parse to parse the date, which doesn't support that (compare JCR-4267). This is a problem, since com.day.jcr.vault:content-package-maven-plugin (I tried versions 0.0.12 and 0.5.4) write package properties using such a format - e.g. 2021-05-26T15:12:21.673+0200 , while org.apache.jackrabbit.util.ISO8601.parse just supports a format like 2021-05-26T15:12:21.673+02:00 . So right now one has to use unpleasant workarounds like using packageProps.getProperty(PackageProperties.NAME_CREATED) and parse that. I suggest changing PackagePropertiesImpl.getDateProperty to support this format, instead.

(Compare also this comment , where that was discussed.)

Issue Links

• relates to: JCRVLT-276 Switch to timezone designators being understood by ISO8601.parse(...)
• links to: GitHub Pull Request #143
• links to: GitHub Pull Request #144