[JCRVLT-343] Check for index definitions also considers ACL entries

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: package-maven-plugin-1.0.4
• Fix Version/s: 3.4.2, package-maven-plugin-1.1.0
• Component/s: package maven plugin
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 23/Jul/19 17:39
• Updated: 15/Jan/20 15:40
• Resolved: 08/Oct/19 15:34

Description

The package for acs-aem-commons contains a rep:policy node at https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/content/src/main/content/jcr_root/_oak_index/_rep_policy.xml. This leads to the following build error when embedding acs-aem-commons-content in your own package as subpackage.

....
[INFO] --- filevault-package-maven-plugin:1.0.4:package (default-package) @ ... ---
[INFO] using meta-inf/vault from /Users/konradwindszus/git/.../src/main/META-INF/vault
[INFO] Scanning files for oak index definitions.
[ERROR]  Package contains index /oak:index/rep:policy in filter, but not in package. Existing index will be removed.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  14.793 s
[INFO] Finished at: 2019-07-25T11:25:51+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package (default-package) on project ...: org.apache.maven.plugin.MojoExecutionException: Package should not contain index definitions, because 'allowIndexDefinitions=false'. -> [Help 1]
[ERROR] 
.

Either the check should be relaxed to skip rep:policy nodes or the warning message should be adjusted.
The issue was originally reported through https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1988.