[JCRVLT-315] Improve error message in case of embedding invalid sub packages

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: package-maven-plugin-1.0.1
• Fix Version/s: package-maven-plugin-1.0.3
• Component/s: package maven plugin
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 10/Aug/18 14:36
• Updated: 05/Sep/18 02:39
• Resolved: 28/Aug/18 04:07

Description

Currently the error message being emitted for invalid ZIP files referenced as sub packages is pretty confusing. It is lacking the original ZIP file name.

An example error message looks like this

[INFO] --- filevault-package-maven-plugin:1.0.2-SNAPSHOT:generate-metadata (default-generate-metadata) @ completepackage ---
[INFO] Embedding --- Sub Packages: groupId=,artifactId=,type=zip,classifier=,filter=true,excludeTransitive=false ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.061 s
[INFO] Finished at: 2018-08-10T16:35:09+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.0.2-SNAPSHOT:generate-metadata (default-generate-metadata) on project completepackage: java.util.zip.ZipException: zip file is empty -> [Help 1]

It is completely lacking the source file name of the sub package which was supposed to be embedded.