Uploaded image for project: 'Jackrabbit FileVault'
  1. Jackrabbit FileVault
  2. JCRVLT-301

Do not always skip installation of sub packages for older versions and log a WARN in case a subpackage is skipped

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.44
    • Fix Version/s: 3.2
    • Component/s: None
    • Labels:
      None

      Description

      With JCRVLT-113 a check was implemented so that sub packages are only installed, in case a newer version of the same package (same package id) is not already installed on the system. Unfortunately in case this happens, the log is only emitted in DEBUG level (so usually not noticeable). This should at least be logged with a WARN (https://github.com/apache/jackrabbit-filevault/blame/58f86f51618c86488234580dfd11e0154fdb471a/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L480).

      Also in some cases you are definitely interested in performing a downgrade. Just think a about an aggregate package which contains not 3rd party subpackages but packages which are part of your own code base. In that case you are actually interested in the downgrade, because you deliberately installed the older aggregate package (which works fine). So this should definitely be parameterizable via the https://github.com/apache/jackrabbit-filevault/blob/0dcf09d58fa40cbe3bc24dcb6a00281123bd5a1c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/SubPackageHandling.java. I am thinking about new options INSTALL_ALWAYS and EXTRACT_ALWAYS which will always install the affected subpackages no matter which version has been installed previously.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                kwin Konrad Windszus
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: