[JCRVLT-155] JcrPackage.isInstalled does not return false in case the package has been overwritten

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.28
• Fix Version/s: 3.1.40
• Component/s: Packaging
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 26/Jan/17 08:02
• Updated: 21/Mar/23 09:09
• Resolved: 08/May/17 02:18

Description

Although the javadoc of o.a.j.v.packaging.JcrPackage#isInstalled() is stating

Checks if this package is installed. Note: the default implementation only checks the JcrPackageDefinition.getLastUnpacked() date. If the package is replaced since it was installed. this method will return false.

this method is returning true in case the package has been reuploaded in between (with the same group, package name and version). This is violating the contract of this method.
Please either fix implementation or javadoc description.

That issue already lead to downstream issues in the com.adobe.granite.installer.factory.packages.impl.PackageTransformer which therefore only installs a package once.

Issue Links

• is related to: JCRVLT-699 Installation of Sub Packages fails if Maven Reproducible Builds are enabled
• is related to: SLING-6484 PackageTransformer will install packages with the same name/group/version only once