[JCR-513] TCK: SetPropertyAssumeTypeTest doesn't allow ValueFormatException upon type conversion failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1
• Component/s: test
• Assignee: Unassigned
• Reporter: David Pitfield
• Created: 26/Jul/06 23:40
• Updated: 04/Aug/06 19:53
• Resolved: 02/Aug/06 16:54

Description

SetPropertyAssumeTypeTest# testValuesConstraintVioloationExceptionBecauseOfInvalidTypeParameter

This test should allow an implementation to throw ValueFormatException. In Section 7.1.5, the Javadoc for setProperty(String, Value[] int) states: "If the property type of the supplied Value objects is different from that specified, then a best-effort conversion is attempted. If the conversion fails, a ValueFormatException is thrown."

Proposal: catch and consume ValueFormatException.

— SetPropertyAssumeTypeTest.java (revision 422074)
+++ SetPropertyAssumeTypeTest.java (working copy)
@@ -28,6 +28,7 @@
import javax.jcr.PropertyType;
import javax.jcr.RepositoryException;
import javax.jcr.Property;
+import javax.jcr.ValueFormatException;
import java.util.Calendar;
import java.util.Date;

@@ -525,6 +526,9 @@
catch (ConstraintViolationException e)

{ // success }

+ catch (ValueFormatException e)

{ + // success + }

}