[JCR-4291] FileInputStream for workspace.xml not closed in RepositoryConfig.loadWorkspaceConfig(File)

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.17.2
• Fix Version/s: 2.18, 2.16.2, 2.17.3, 2.14.6, 2.12.10, 2.10.9, 2.8.10
• Component/s: config
• Assignee: Julian Reschke
• Reporter: Jan Quadflieg
• Created: 30/Apr/18 07:23
• Updated: 27/Sep/19 11:17
• Resolved: 30/Apr/18 08:49

Description

As already said in the summary: The FileInputStream in RepositoryConfig.loadWorkspaceConfig(File) is not closed. This open file handle prevents the repository from being deleted (we use a simple TransientRepository in unit tests which gets deleted after each test). The obvious fix is simple:

Buggy Code:

try {
  File file = new File(directory, WORKSPACE_XML);
  InputSource xml = new InputSource(new FileInputStream(file));
  // ...
} catch (FileNotFoundException e) {
  return null;
}

Fixed Code:

FileInputStream fin = null;
try {
  File file = new File(directory, WORKSPACE_XML);
  fin = new FileInputStream(file);
  InputSource xml = new InputSource(fin);
  // ...
} catch (FileNotFoundException e) {
  return null;
} finally {
  IOUtils.closeQuietly(fin);
}

The attached patch file has been created from the 2.17.2 source.