[JCR-3571] Light optimization for CachingNameResolver.getJCRName(Name)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.13, 2.4.3, 2.5.3, 2.6
• Fix Version/s: 2.7
• Component/s: jackrabbit-spi-commons
• Assignee: Unassigned
• Reporter: Sergiy Shyrkov
• Created: 17/Apr/13 10:18
• Updated: 10/May/13 19:44
• Resolved: 22/Apr/13 09:04

Description

In case of a Name which has no namespace (name.getNamespaceURI().length() == 0) there is perhaps no need to cache the resolved jcrName as it will be getLocalName().

If this is true, than I would like to suggest the following slight optimization in the org.apache.jackrabbit.spi.commons.conversion.CachingNameResolver.getJCRName(Name) method:

public String getJCRName(Name name) throws NamespaceException {
if (name.getNamespaceURI().length() == 0)

{ return name.getLocalName(); }

String jcrName = (String) cache.get(name);
...

This will return earlier and "save" the lookup in the cache and further cache.put() (the GenerationalCache.put(Object, Object) is synchronized so avoiding the call makes things potentially faster).

Thank you in advance!