Jackrabbit Content Repository
  1. Jackrabbit Content Repository
  2. JCR-3497

Invalid path in SaveTest#testRepositoryException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.3
    • Fix Version/s: 2.6
    • Component/s: jackrabbit-jcr-tests
    • Labels:
      None

      Description

      org.apache.jackrabbit.test.api.query.SaveTest.testRepositoryException() passes a syntactically invalid path to Query.storeAsNode() and expects a RepositoryException.

      I think we should change this and pass a syntactically correct path that has an index on its last element. I believe this matches the initial intention of this test much better.

      The current test prevents other JCR implementations from throwing an IllegalArgumentException for syntactically invalid paths. See also https://issues.apache.org/jira/browse/OAK-563?focusedCommentId=13556369&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13556369.

      1. JCR-3497.patch
        0.9 kB
        Michael Dürig

        Activity

        Hide
        Jukka Zitting added a comment -

        Merged to the 2.6 branch in revision 1440090.

        Show
        Jukka Zitting added a comment - Merged to the 2.6 branch in revision 1440090.
        Hide
        Michael Dürig added a comment -

        Fixed at revision 1437928.

        Show
        Michael Dürig added a comment - Fixed at revision 1437928.
        Hide
        Michael Dürig added a comment -

        proposed patch

        Show
        Michael Dürig added a comment - proposed patch

          People

          • Assignee:
            Michael Dürig
            Reporter:
            Michael Dürig
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development