[JCR-3434] EventJournal#skipTo() broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.12, 2.4.3, 2.5.2
• Fix Version/s: 2.2.13, 2.4.4, 2.5.3
• Component/s: jackrabbit-core
• Assignee: Unico Hommes
• Reporter: Lars Michele
• Created: 27/Sep/12 18:41
• Updated: 04/Oct/12 10:33
• Resolved: 29/Sep/12 08:01

Description

There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:

Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
===================================================================
— src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
+++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
@@ -135,7 +135,7 @@
// get skip map for this journal
SortedMap<Long, Long> skipMap = getSkipMap();
synchronized (skipMap) {

• SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
  + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
  if (!head.isEmpty()) {
  eventBundleBuffer.clear();
  lastRevision = head.get(head.lastKey());