> a tiny feedback on your patch
> I think it would be better if the test was in the "ExcerptTest" class.
Yep; I just did that.
> I like the "escape" refactoring.
>Why is it not static? Text.encodeIllegalXMLCharacters is static, what is the gain of adding a non-static method to call a static one?
It needs to be non-static to that classes that extend from the DefaultHighLighter can override it.
> What is the benefit of making methods non static?
So that they can call the other methods I made non-static for the reason above