[JCR-3006] UserManager: concurrent user creation using same intermediate path fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.7
• Fix Version/s: 2.3
• Component/s: security
• Assignee: Unassigned
• Reporter: Stefan Guggisberg
• Created: 27/Jun/11 16:27
• Updated: 08/Nov/11 15:55
• Resolved: 30/Sep/11 13:32

Description

concurrently creating users using same intermediate path fails with "node ... has been modified externally".

the problem is the intermediate path. if it doesn't exist multiple threads try to create it concurrently:

o.a.jackrabbit.core.security.user.UserManagerImpl, line 1310ff:

String[] segmts = defaultPath.split("/");
NodeImpl folder = (NodeImpl) session.getRootNode();
String authRoot = (isGroup) ? groupsPath : usersPath;

for (String segment : segmts) {
if (segment.length() < 1)

{ continue; }

if (folder.hasNode(segment)) {
folder = (NodeImpl) folder.getNode(segment);
if (Text.isDescendantOrEqual(authRoot, folder.getPath()) &&
!folder.isNodeType(NT_REP_AUTHORIZABLE_FOLDER))

{ throw new ConstraintViolationException("Invalid intermediate path. Must be of type rep:AuthorizableFolder."); }

} else

{ Node parent = folder; folder = addNode(folder, session.getQName(segment), NT_REP_AUTHORIZABLE_FOLDER); }

}

the attached test case illustrates this issue/