Jackrabbit Content Repository
  1. Jackrabbit Content Repository
  2. JCR-1556

PersistenceManager API change breaks backward compatibility

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: core 1.4.3
    • Fix Version/s: core 1.4.4
    • Component/s: jackrabbit-core
    • Labels:
      None

      Description

      Persistence Manager API change introduced in JCR-1428 breaks backward compatibility. although this is not a public visible API it renders 3rd party PMs invalid that do not extend from AbstractPersistenceManager.
      at least for the 1.4.3 patch release, we should not do this.

      suggest to revert the API change for the next 1.4.4 release, but leave the method on the abstract pm, and introduce it only for 1.5.

        Activity

        Tobias Bocanegra created issue -
        David Nuescheler made changes -
        Field Original Value New Value
        Summary PersistenceManager API change breacks backward compatibility PersistenceManager API change breaks backward compatibility
        Jukka Zitting made changes -
        Assignee Jukka Zitting [ jukkaz ]
        Hide
        Jukka Zitting added a comment -

        Once svn works again, I plan to fix this simply by commenting out the method in the PersistenceManager interface:

        Index: jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/PersistenceManager.java
        ===================================================================
        — jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/PersistenceManager.java (revision 650539)
        +++ jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/PersistenceManager.java (working copy)
        @@ -197,6 +197,8 @@

        • repaired. if false, no data will be modified, instead all
        • inconsistencies will only get logged
          */
        • void checkConsistency(String[] uuids, boolean recursive, boolean fix);
          + // JCR-1556: This method will be introduced in 1.5
          + // If you need it before, cast to AbstractPersistenceManager
          + // void checkConsistency(String[] uuids, boolean recursive, boolean fix);

        }

        Show
        Jukka Zitting added a comment - Once svn works again, I plan to fix this simply by commenting out the method in the PersistenceManager interface: Index: jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/PersistenceManager.java =================================================================== — jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/PersistenceManager.java (revision 650539) +++ jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/PersistenceManager.java (working copy) @@ -197,6 +197,8 @@ repaired. if false, no data will be modified, instead all inconsistencies will only get logged */ void checkConsistency(String[] uuids, boolean recursive, boolean fix); + // JCR-1556 : This method will be introduced in 1.5 + // If you need it before, cast to AbstractPersistenceManager + // void checkConsistency(String[] uuids, boolean recursive, boolean fix); }
        Jukka Zitting made changes -
        Fix Version/s core 1.4.4 [ 12313135 ]
        Hide
        Jukka Zitting added a comment -

        Fixed as proposed in revision 653348 (1.4 branch only).

        Show
        Jukka Zitting added a comment - Fixed as proposed in revision 653348 (1.4 branch only).
        Jukka Zitting made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jukka Zitting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jukka Zitting made changes -
        Workflow jira [ 12429895 ] no-reopen-closed, patch-avail [ 12468509 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7d 21h 15m 1 Jukka Zitting 05/May/08 08:22
        Resolved Resolved Closed Closed
        246d 7h 38m 1 Jukka Zitting 06/Jan/09 16:01

          People

          • Assignee:
            Jukka Zitting
            Reporter:
            Tobias Bocanegra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development