[JCR-1540] BundleDbPersistenceManager.checkConsistency() only fixes inconsistency if consistencyFix is enabled in configuration

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4, core 1.4.1, core 1.4.2
• Fix Version/s: core 1.4.3
• Component/s: jackrabbit-core
• Assignee: Unassigned
• Reporter: Marcel Reutegger
• Created: 16/Apr/08 10:20
• Updated: 06/Jan/09 16:01
• Resolved: 16/Apr/08 10:24

Description

The method has a parameter that explicitly tells whether an inconsistency should be fixed, thus the configuration parameter should be ignored.

Suggested patch:

Index: BundleDbPersistenceManager.java
===================================================================
— BundleDbPersistenceManager.java (revision 648657)
+++ BundleDbPersistenceManager.java (working copy)
@@ -864,7 +864,7 @@
}

// repair collected broken bundles

• if (consistencyFix && !modifications.isEmpty()) {
  + if (fix && !modifications.isEmpty()) {
  log.info(name + ": Fixing " + modifications.size() + " inconsistent bundle(s)...");
  Iterator iterator = modifications.iterator();
  while (iterator.hasNext()) {