[JCR-1398] [PATCH] ClassDescriptor.hasIdField uses faulty logic

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Component/s: jackrabbit-ocm
• Assignee: Christophe Lombart
• Reporter: David Brosius
• Created: 20/Feb/08 02:58
• Updated: 08/Dec/08 11:09
• Resolved: 02/Mar/08 23:11

Description

hasIdField tries to compare a FieldDescriptor to an empty string, which doesn't make sense, here:

public boolean hasIdField()

{ return (this.idFieldDescriptor != null && ! this.idFieldDescriptor.equals("")); }

i'm assuming it should be

return (this.idFieldDescriptor != null && this.idFieldDescriptor.isId());

patch does this