Uploaded image for project: 'Jackrabbit Content Repository'
  1. Jackrabbit Content Repository
  2. JCR-1277

ConnectionRecoveryManager is created twice in DBDataStore init method

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: jackrabbit-core
    • Labels:
      None

      Description

      It seems that after introducing pool, old initizialization of ConnectionRecoveryManager has not been removed.

      Index: DbDataStore.java
      ===================================================================
      — DbDataStore.java (revision 605626)
      +++ DbDataStore.java (working copy)
      @@ -479,8 +479,6 @@
      initDatabaseType();
      connectionPool = new Pool(this, maxConnections);
      ConnectionRecoveryManager conn = getConnection();

      • conn = new ConnectionRecoveryManager(false, driver, url, user, password);
      • conn.setAutoReconnect(true);
        DatabaseMetaData meta = conn.getConnection().getMetaData();
        log.info("Using JDBC driver " + meta.getDriverName() + " " + meta.getDriverVersion());
        meta.getDriverVersion();

      Duplicated initialization should be removed , but i've never run this code yet.

        Attachments

          Activity

            People

            • Assignee:
              thomasm Thomas Mueller
              Reporter:
              ppakulski Przemyslaw Pakulski
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: