[JCR-1277] ConnectionRecoveryManager is created twice in DBDataStore init method

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.4
• Component/s: jackrabbit-core
• Assignee: Thomas Mueller
• Reporter: Przemyslaw Pakulski
• Created: 19/Dec/07 17:30
• Updated: 15/Jan/08 23:27
• Resolved: 21/Dec/07 12:22

Description

It seems that after introducing pool, old initizialization of ConnectionRecoveryManager has not been removed.

Index: DbDataStore.java
===================================================================
— DbDataStore.java (revision 605626)
+++ DbDataStore.java (working copy)
@@ -479,8 +479,6 @@
initDatabaseType();
connectionPool = new Pool(this, maxConnections);
ConnectionRecoveryManager conn = getConnection();

• conn = new ConnectionRecoveryManager(false, driver, url, user, password);
• conn.setAutoReconnect(true);
  DatabaseMetaData meta = conn.getConnection().getMetaData();
  log.info("Using JDBC driver " + meta.getDriverName() + " " + meta.getDriverVersion());
  meta.getDriverVersion();

Duplicated initialization should be removed , but i've never run this code yet.