Jackrabbit Content Repository
  1. Jackrabbit Content Repository
  2. JCR-1263

Move SimpleWebdavServlet to jcr-server and make it abstract

    Details

      Description

      In line with isse JCR-417, I suggest to partially move the SimpleWebdavServlet from the jcr-webapp project to the jcr-server project. By partially I mean, that the new (moved) servlet will be abstract and the getRepository() method will be abstract. The jcr-webapp project will still contain a SimpleWebdavServlet (for backwards compatibility maintaing the same name) which just extends the new servlet and implements the getRepository() method using the RepositoryAccess servlet.

      This allows for the reuse of the jcr-server project including the abstract SimpleWebdavServlet in other environments. My intention is to include this project (along with the webdav) project in Sling.

      Will provide a patch for this proposal

      (This issue is separated out of JCR-1262 as suggested by Angela)

      1. JCR-1263.patch
        25 kB
        Felix Meschberger

        Issue Links

          Activity

          Hide
          Felix Meschberger added a comment -

          Patch to the jackrabbit-jcr-server and jackrabbit-webapp project implementing the changes:

          • Copy SimpleWebdavServlet to jackrabbit-jcr-server project
          • Make getRepository method and whole class abstract
          • Remove setRepository method and private repository field
          • Remove all methods and fields except private repository field and
            setRepository and getRepository methods from the old SimpleWebdavServlet
          • Have the old SimpleWebdavServlet extend the new (abstract) SimpleWebdavServlet
          Show
          Felix Meschberger added a comment - Patch to the jackrabbit-jcr-server and jackrabbit-webapp project implementing the changes: Copy SimpleWebdavServlet to jackrabbit-jcr-server project Make getRepository method and whole class abstract Remove setRepository method and private repository field Remove all methods and fields except private repository field and setRepository and getRepository methods from the old SimpleWebdavServlet Have the old SimpleWebdavServlet extend the new (abstract) SimpleWebdavServlet
          Hide
          angela added a comment -

          fine with me.
          do you want to commit it or should i?

          and: would it make sense to do the same for the JCRWebdavServerServlet?
          what do yo think?

          Show
          angela added a comment - fine with me. do you want to commit it or should i? and: would it make sense to do the same for the JCRWebdavServerServlet? what do yo think?
          Hide
          Felix Meschberger added a comment -

          I can do that, just wanted to wait for your OK.

          And yes, it would definitely make sense for the JCRWebdavServerServlet, too. Will create an issue and implement the fix at the same time.

          Show
          Felix Meschberger added a comment - I can do that, just wanted to wait for your OK. And yes, it would definitely make sense for the JCRWebdavServerServlet, too. Will create an issue and implement the fix at the same time.
          Hide
          Felix Meschberger added a comment - - edited

          Fixed in Rev.603178.

          Show
          Felix Meschberger added a comment - - edited Fixed in Rev.603178.
          Hide
          Felix Meschberger added a comment -

          This issue implements part of JCR-417.

          Show
          Felix Meschberger added a comment - This issue implements part of JCR-417 .
          Hide
          Felix Meschberger added a comment -

          Schedule for 1.4

          Show
          Felix Meschberger added a comment - Schedule for 1.4

            People

            • Assignee:
              Felix Meschberger
              Reporter:
              Felix Meschberger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development