[JCLOUDS-835] filesystem blobstore does not atomically replace objects

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.1
• Fix Version/s: 2.0.0
• Component/s: jclouds-blobstore
• Labels: filesystem
• Assignee: Andrew Gaul
• Reporter: Andrew Gaul
• Created: 03/Mar/15 22:36
• Updated: 20/Nov/15 22:46
• Resolved: 20/Nov/15 22:46

Description

Object stores have atomic replacement of keys, i.e., a mutating operation like write or overwrite should succeed and expose the new object or fail and retain the old object. The filesystem blobstore does neither of these and also has issues when handling simultaneous writes. From FilesystemStorageStrategyImpl.putBlob:

try {
   outputFile.delete();
   Files.asByteSink(outputFile).writeFrom(his);
   ...
} catch (IOException ex) {
   if (outputFile != null) {
      if (!outputFile.delete()) {
         logger.debug("Could not delete %s", outputFile);
      }
   }
   throw ex;
}

Instead we should write to a temporary file and rename on top of the target object.