[JCLOUDS-1631] AWS S3, sign for authorization header failed if query part contains special chars

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.6.1
• Component/s: jclouds-blobstore
• Labels: s3
• Assignee: Andrew Gaul
• Reporter: Maksim Hadalau
• Created: 18/Mar/24 18:08
• Updated: 16/Nov/24 00:14
• Resolved: 14/Apr/24 08:38

Description

Problem description:
Can not list blobs for aws-s3 provider if prefix contains special chars %/&

Steps to reproduce:
try to list blobs with following prefix: 
"Folder (`~!@#$%^&*-_+[]'|<>.?) Name/"

Actual behavior:
Error: URLDecoder: Incomplete trailing escape (%) pattern

Expected behavior:
provided prefix must be listed

Problem location:

`AWSRequestAuthorizeSignatureV4.signForAuthorizationHeader()`

 
Multimap<String, String> queryMap = queryParser().apply(request.getEndpoint().getQuery());

request.getEndpoint().getQuery() - returns a decoded query string
however queryParser() require encoded one

Fix:
Multimap<String, String> queryMap = queryParser().apply(request.getEndpoint().getRawQuery());

When jclouds generates a request to the AWS it encodes prefix (encoding all special chars in it, including % and &), however calling `getQuery()` returns decoded version of query string which lead to unpredictable behavior. 

P.S. required patch in 2.5.x if possible

PR https://github.com/apache/jclouds/pull/200