Uploaded image for project: 'jclouds'
  1. jclouds
  2. JCLOUDS-1297

Swift Multipart uploadId Format Problem

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1.0, 2.0.2
    • Component/s: jclouds-blobstore
    • Labels:
      None
    • Environment:
      Java 8

      Description

      Generated UploadId is not unique for diffrent Locales.

      Locale French (includes comma):
      hello/slo/1494603748,474000/43/33554432

      Locale English (includes dot):
      hello/slo/1494603748.474000/43/33554432

      Could you please add Locale.ENGLISH param to String.format method call.

            String uploadId = String.format(Locale.ENGLISH, "%s/slo/%.6f/%s/%s", blobMetadata.getName(),
                    System.currentTimeMillis() / 1000.0, contentLength == null ? Long.valueOf(0) : contentLength,
                    partSize);
      

      https://github.com/jclouds/jclouds/blob/8649002e03314e3e4ebe436021e5db56c20500a5/apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java#L475

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f7cad22d937025e46110c93d93a8a7cb5ea630c3 in jclouds's branch refs/heads/2.0.x from ui4j
        [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=f7cad22 ]

        JCLOUDS-1297: Fix uploadId format for non-English locale

        Add Locale.ENGLISH parameter to String.format(...) to generate same uploadId for different locales.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f7cad22d937025e46110c93d93a8a7cb5ea630c3 in jclouds's branch refs/heads/2.0.x from ui4j [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=f7cad22 ] JCLOUDS-1297 : Fix uploadId format for non-English locale Add Locale.ENGLISH parameter to String.format(...) to generate same uploadId for different locales.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a299a6c1fdfff5669d2f9bc830e6b2df96bec1a8 in jclouds's branch refs/heads/master from ui4j
        [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=a299a6c ]

        JCLOUDS-1297: Fix uploadId format for non-English locale

        Add Locale.ENGLISH parameter to String.format(...) to generate same uploadId for different locales.

        Show
        jira-bot ASF subversion and git services added a comment - Commit a299a6c1fdfff5669d2f9bc830e6b2df96bec1a8 in jclouds's branch refs/heads/master from ui4j [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=a299a6c ] JCLOUDS-1297 : Fix uploadId format for non-English locale Add Locale.ENGLISH parameter to String.format(...) to generate same uploadId for different locales.
        Hide
        gaul Andrew Gaul added a comment -

        Özhan Düz This sounds reasonable – can you submit a pull request as documented here:

        https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute

        Show
        gaul Andrew Gaul added a comment - Özhan Düz This sounds reasonable – can you submit a pull request as documented here: https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute

          People

          • Assignee:
            gaul Andrew Gaul
            Reporter:
            ozhan Özhan Düz
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development