[JCLOUDS-1141] Azurecompute - RoleToXML doesn't close the ConfigurationSets element corretly

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: jclouds-labs
• Labels: azurecompute
• Assignee: Unassigned
• Reporter: Josef Cacek
• Created: 16/Jul/16 10:28
• Updated: 17/Jul/16 21:50
• Resolved: 17/Jul/16 21:50

Description

There is a missing .up() call for "ConfigurationSets" element in RoleToXML class.

So the generated XML looks like:

<PersistentVMRole xmlns="http://schemas.microsoft.com/windowsazure">
  <RoleName>...</RoleName>
  <RoleType>PersistentVMRole</RoleType>
  <ConfigurationSets>
    <ConfigurationSet>...</ConfigurationSet>
    <DataVirtualHardDisks/><OSVirtualHardDisk>...</OSVirtualHardDisk>
    <RoleSize>Basic_A1</RoleSize>
  </ConfigurationSets>
</PersistentVMRole>

The correct output is:

<PersistentVMRole xmlns="http://schemas.microsoft.com/windowsazure">
  <RoleName>...</RoleName>
  <RoleType>PersistentVMRole</RoleType>
  <ConfigurationSets>
    <ConfigurationSet>...</ConfigurationSet>
  </ConfigurationSets>
  <DataVirtualHardDisks/>
  <OSVirtualHardDisk>...</OSVirtualHardDisk>
  <RoleSize>Basic_A1</RoleSize>
</PersistentVMRole>

See https://msdn.microsoft.com/en-us/library/azure/jj157187.aspx