Uploaded image for project: 'jclouds'
  1. jclouds
  2. JCLOUDS-1021

Add JavaDoc to repoTags() value in org.jclouds.docker.domain.Image

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.9.2, 2.0.0
    • Component/s: jclouds-labs
    • Labels:

      Description

      Updated
      The org.jclouds.docker.domain.Image class contains repoTags field, which is empty by default. The ImageApi.inspectImage() method which returns Image instances doesn't retrieve info about the tags.

      User can retrieve tags by using ImageApi.listImages() method which returns List<ImageSummary>. The ImageSummary instances correctly contain the tag information.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 498f1d820747823f5a03e485a0768b74478ff7a6 in jclouds-labs's branch refs/heads/1.9.x from Josef Cacek
        [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=498f1d8 ]

        JCLOUDS-1021 Add JavaDoc to cover behavior of repoTags() method in org.jclouds.docker.domain.Image

        Show
        jira-bot ASF subversion and git services added a comment - Commit 498f1d820747823f5a03e485a0768b74478ff7a6 in jclouds-labs's branch refs/heads/1.9.x from Josef Cacek [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=498f1d8 ] JCLOUDS-1021 Add JavaDoc to cover behavior of repoTags() method in org.jclouds.docker.domain.Image
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ea28b9099335d804e4b5aaff839b0bfdf46d3950 in jclouds-labs's branch refs/heads/master from Josef Cacek
        [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=ea28b90 ]

        JCLOUDS-1021 Add JavaDoc to cover behavior of repoTags() method in org.jclouds.docker.domain.Image

        Show
        jira-bot ASF subversion and git services added a comment - Commit ea28b9099335d804e4b5aaff839b0bfdf46d3950 in jclouds-labs's branch refs/heads/master from Josef Cacek [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=ea28b90 ] JCLOUDS-1021 Add JavaDoc to cover behavior of repoTags() method in org.jclouds.docker.domain.Image
        Show
        kwart Josef Cacek added a comment - PR sent: https://github.com/jclouds/jclouds-labs/pull/211
        Hide
        kwart Josef Cacek added a comment - - edited

        Digging deeper in the code, I've found I was wrong about stating it's always emtpy. It's empty when retrieved from the ImageApi call. Nevertheless, the method org.jclouds.docker.compute.strategy.DockerComputeServiceAdapter.listImages() recreates the Image instance and fills the repoTags field with the missing info retrieved from ImageApi.listImages method.

        IMO, It could be sufficient to cover the behavior in the JavaDoc (e.g. for ImageApi.inspectImage() method).

        Show
        kwart Josef Cacek added a comment - - edited Digging deeper in the code, I've found I was wrong about stating it's always emtpy. It's empty when retrieved from the ImageApi call. Nevertheless, the method org.jclouds.docker.compute.strategy.DockerComputeServiceAdapter.listImages() recreates the Image instance and fills the repoTags field with the missing info retrieved from ImageApi.listImages method. IMO, It could be sufficient to cover the behavior in the JavaDoc (e.g. for ImageApi.inspectImage() method).

          People

          • Assignee:
            Unassigned
            Reporter:
            kwart Josef Cacek
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development