[JCI-58] EclipseJavaCompiler fails to close inputstream

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1
• Fix Version/s: 1.1
• Component/s: compiler eclipse

Environment

Java 1.5, WinXP

• Assignee: Torsten Curdt
• Reporter: Michael Gannon
• Created: 03/Dec/08 04:07
• Updated: 14/Oct/13 13:47
• Resolved: 13/May/11 08:19

Description

The method isPackage(final String pClaszzName) calls classLoader.getResourceAsStream() but fails to close the stream if it is opened successfully. On Windows this means all other file access to this file is not permitted. The inputstream should be closed. Here is a replacement method:

    private boolean isPackage( final String pClazzName ) {

        final InputStream is = pClassLoader.getResourceAsStream(ConversionUtils.convertClassToResourcePath(pClazzName));
        if (is != null) {
            log.debug("found the class for " + pClazzName + "- no package");
            try {
                is.close();
            } catch (final IOException ie) {
                log.error("could not close input stream", ie);
            } 
            return false;
        }

        // FIXME: this should not be tied to the extension
        final String source = pClazzName.replace('.', '/') + ".java";
        if (pReader.isAvailable(source)) {
            log.debug("found the source " + source + " for " + pClazzName + " - no package ");
            return false;
        }

        return true;
    }