[JCI-46] Add Guard conditions to logging statements

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.0RC2
• Component/s: compiler eclipse, compiler groovy, compiler janino, compiler javac, compiler jsr199, compiler jython, compiler rhino, core, fam
• Assignee: Unassigned
• Reporter: Niall Pemberton
• Created: 19/Apr/07 15:28
• Updated: 02/May/07 13:08
• Resolved: 02/May/07 13:08

Description

The lack of Guard conditions on logging statements that concatenate objects to create the logging output results in unecessary StringBuffer creation when the logging level is below the threshold set.

Would be a good idea IMO to change statements like:

log.debug(getId() + " found class: " + name + " (" + clazzBytes.length + " bytes)");

to

if (log.isDebugEnabled())

{ log.debug(getId() + " found class: " + name + " (" + clazzBytes.length + " bytes)"); }