[JAMES-932] James 'initialize' reports deprecated config <usernames> <servernames>

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 3.0-M1
• Component/s: James Core
• Environment: http://svn.apache.org/repos/asf/james/server/trunk
• Assignee: Norman Maurer
• Reporter: Mark DeBusschere
• Created: 14/Oct/09 17:55
• Updated: 23/Jan/10 11:35
• Resolved: 23/Jan/10 11:35

Description

During start log messages such as

<usernames> parameter in James block is deprecated. Please configure this data in UsersRepository block: configuration injected for backward compatibility

and

<servernames> parameter in James block is deprecated. Please configure this data in domainlist block: configuration injected for backward compatibility

The code in org.apache.james.James.initialize()
uses the following test conditions

Configuration userNamesConf = conf.getChild("usernames");
if (userNamesConf != null)

{ ..}

Configuration serverConf = conf.getChild("servernames");
if (serverConf != null)

{ .. }

The javadocs for org.apache.avalon.framework.configuration.Configuration state
a test for null should use getChild(String, boolean)

The current james-config.xml has these listed as deprecated and remd out.
For this test condition, the method should return null.

I believe the following would be correct for this situation.

userNamesConf = conf.getChild("usernames",false);

and

Configuration serverConf = conf.getChild("servernames", false);

The following could be an issue, but they are still valid in james-config.xml.

virtualHostingConfig = conf.getChild("enableVirtualHosting");
defaultDomainConfig = conf.getChild("defaultDomain");
helloNameConfig = conf.getChild("helloName");