[JAMES-445] Enforcement for HELO/EHLO commands before MAIL

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.0, 2.3.0
• Fix Version/s: 2.3.0
• Component/s: SMTPServer
• Assignee: Stefano Bagnara
• Reporter: Stefano Bagnara
• Created: 23/Feb/06 05:55
• Updated: 21/Nov/07 08:31
• Resolved: 01/Mar/06 19:34

Description

From Norman Maurer:

Hi,

this is my first Patch so i hope its correct posted and made.. It patch
the MailCmdHandler to check if a HELO was provided..

So HELO should be provided as first command.. this is wrote down in the
RFC. So before accept MAIL FROM the HELO must provided..

Comments are welcome

bye
Norman

-----------------------------------------------

— MailCmdHandlerOLD.java 2006-02-17 12:23:26.000000000 +0100
+++ MailCmdHandler.java 2006-02-17 12:25:34.000000000 +0100
@@ -29,6 +29,8 @@
public class MailCmdHandler
extends AbstractLogEnabled
implements CommandHandler {
+
+ private final static String CURRENT_HELO_MODE = "CURRENT_HELO_MODE"; // HELO or EHLO

private final static String MAIL_OPTION_SIZE = "SIZE";

@@ -70,6 +72,9 @@

sender == null) { responseString = "501 "+DSNStatus.getStatus(DSNStatus.PERMANENT,DSNStatus.DELIVERY_INVALID_ARG)+" Usage: MAIL FROM:<sender>"; session.writeResponse(responseString); + } else if (session.getState().containsKey(CURRENT_HELO_MODE) == false ) { + responseString = "501 "+DSNStatus.getStatus(DSNStatus.PERMANENT,DSNStatus.DELIVERY_INVALID_ARG)+" HELO needed first"; + session.writeResponse(responseString); } else { sender = sender.trim(); // the next gt after the first lt ... AUTH may add more <>