[JAMES-3917] Maven build should be strict about Scala imports ordering in the code

• Type: New Feature
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: master
• Assignee: Unassigned
• Reporter: Tung TRAN
• Created: 23/Jun/23 07:13
• Updated: 11/Jul/23 09:43
• Resolved: 11/Jul/23 09:43

Description

For now, we do not have strict rules with Scala regarding import orders. Not everybody has the same layout and it potentially reduces readability in PRs on code change if somebody got a different import layout than the initial code.

We should be more strict on import ordering like we do with Java.

Proposed layout:

base package imports
___blank line___
java
___blank line___
all other imports
___blank line___
scala

Should modify the scalafix maven plugin to do a strict check on import and fail the build if that last one isn't respected.  

Issue Links

• links to: GitHub Pull Request #1604