[JAMES-3712] Bounce does not add prefix to the sent email

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Mailet Contributions
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 03/Feb/22 15:32
• Updated: 08/Feb/22 02:04
• Resolved: 08/Feb/22 02:04

Description

Reported by @ljose on gitter

While upgrading from 2.6 to 3.6 he noticed a breaking change to Bounce mailet, not adding the prefix to the sent email, and instead adding it to the email in flight.

To quote him "It looks like it is prefixed with "Undeliverable" after Bounce, but when it comes in as a new incoming mail, the subject is without the prefix."

CF https://gitter.im/apache/james-project?at=61fb3bbe3349fe1c71f18823

1. Its friend, DSNBounce does modify the sent message, not the in flight one (what is described above)

2. This seems logical that DSNBounce modifies the sent email: itself knows how to modify it. The in flight message could still be modified by follow up mailets

3. The refactoring of Bounce* classes was done with an emphase on preserving behaviour, without questionning it - what I am doing here. To be fairly honnest I bet on a copy-and-paste mistake that was never questionned, and duplicated to other classes.

After a short review, a few other mailets are impacted too: NotifySender + NotifyPostmaster...

Issue Links

• links to: GitHub Pull Request #873