[JAMES-3696] Solve instable test for the pulsar mail queue

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: master
• Component/s: pulsar, Queue
• Labels: bug
• Assignee: Jean Helou
• Reporter: Benoit Tellier
• Created: 11/Jan/22 02:15
• Updated: 26/Sep/24 21:05
• Resolved: 26/Sep/24 21:05

Description

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-826/7/

Pulsar mail queue bringed in some unstable tests

Test Result (4 failures / +4)

    org.apache.james.queue.pulsar.PulsarMailQueueTest.removeByRecipientShouldRemoveSpecificEmail
    org.apache.james.queue.pulsar.PulsarMailQueueTest.removeByRecipientShouldRemoveSpecificEmailWhenMultipleRecipients{List, MailAddress}[5]
    org.apache.james.queue.pulsar.PulsarMailQueueTest.removeByRecipientShouldRemoveSpecificEmailWhenMultipleRecipients{List, MailAddress}[6]
    org.apache.james.queue.pulsar.PulsarMailQueueTest.removeShouldRemoveMailFromStoreWhenFilteredOut

Looking at the first, some email expected to be deleted were not:

Error Message

Expecting actual:
  ["name1", "name2"]
to contain exactly (and in same order):
  ["name1"]
but some elements were not expected:
  ["name2"]

Maybe because propagation of the delete filter is asynchronous? (IE the client delete returns when enqueuing the filter but without any warranty so as when it would be dequeued and applied). If so this isa design flaw and I hardly see how to improve that .

Or we add a delay in the tests to relax the consistency guaranty?

Issue Links

• links to: GitHub Pull Request #1211
• links to: GitHub Pull Request #2416