[JAMES-3620] Memory leak at org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Component/s: Metrics, protocols, SMTPServer

Language

Java

• Assignee: Unassigned
• Reporter: tuister
• Created: 28/Jul/21 02:28
• Updated: 12/Aug/21 06:53
• Resolved: 12/Aug/21 06:53

Description

For each command, the command handler will use a timer record the rt. So, if someone input error commands, the command handler will create a new timer to record, this will cause memory leak.

//AbstractHookableCmdHandler#onCommand
//see also org.apache.james.protocols.smtp.core.UnknownCmdHandler
TimeMetric timeMetric = metricFactory.timer("SMTP-" + request.getCommand().toLowerCase(Locale.US));

 

 

Issue Links

• links to: GitHub Pull Request #563