[JAMES-3602] AmqpForwardAttributed was opening a connection per call

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Done
• Affects Version/s: 3.6.0
• Fix Version/s: 3.7.0
• Component/s: Mailet Contributions, rabbitmq
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 19/Jun/21 07:04
• Updated: 21/Jun/21 04:27
• Resolved: 21/Jun/21 04:27

Description

One connection and one channel is opened per processed emails. Connections and channels are long lived objects, made to be reused. Flamme graphs showed that this AMQP mailet represents ~1% of CPU occupation with just about 30 mail/sec. Note that 92% of this time is used opening/closing connections/channels. Moving connection and channel initialisation at mailet initialisation enables reuse and leads to dramatic enhancements of the performances of that very mailet. Note that retries are in place in case Rabbit is not up right at start - common with IE docker-compose. The testing strategy relying on mocks is brittle. Given that we have full-fledged integration tests in place, we can get rid of these annoying mock-based tests. - Move AmqpForwardAttribute to a separated maven module - AmqpForwardAttribute should use backend-rabbitmq It cares for us about channel thread safety upon reuse, connection and channel reconfiguration.

Issue Links

• links to: GitHub Pull Request #502