Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-2547

Replace concrete PropertiesConfiguration type by Configuration interface in PropertiesProvider

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.2.0
    • configuration
    • None

    Description

      This makes testing configuration components easier.

      For exemple  subclassing  PropertiesProvider to make it return an in memory configuration such as a MapConfiguration instead of being bound to the concrete PropertiesConfiguration implementation.

      I have found no place in the project where relying on the concrete type is actually useful. All uses were replaceable by the interface or by a static call to the top of the hierarchy (AbstractConfiguration).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            jeantil Jean Helou
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment