[JAMES-1019] getDomainsInternal in JDBCVirtualUserTable needs reworked

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 3.0-M1
• Component/s: UsersStore & UsersRepository
• Assignee: Norman Maurer
• Reporter: Jeff Huff
• Created: 18/Jun/10 21:45
• Updated: 03/Sep/10 09:10
• Resolved: 19/Jun/10 15:50

Description

FindBugs reports the following error in JDBCVirtualUserTable.java

C:/svnpublic/james-server/user-function/src/main/java/org/apache/james/vut/JDBCVirtualUserTable.java:504 Call to equals() comparing different types

Should probably be more like this...

String domain = mappingRS.getString(1).toLowerCase();
if(domain.equals(WILDCARD) == false && domains.contains(domain) == false)

{ domains.add(domain); }