IvyDE
  1. IvyDE
  2. IVYDE-42

Why the 'Resolve all' action is not plugged in the workbench

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 2.0.0.alpha1
    • Component/s: classpath container
    • Labels:
      None

      Description

      I have recentlty looked in the source code and I have noticed that there is a 'Resolve all' action.
      Unfortunately, it seems it is not plugged in the workbench. Why is it not ?

      In fact, my need is to be able to resolve dependencies on several projects at one time.
      Thoughts ?

        Activity

        Hide
        Thomas Friol added a comment -

        Unfortunately, I did not find the way to attach a file to this issue, so here is a patch to plug the action in the workbench :

        — plugin.xml.orig 2006-11-07 11:40:42.000000000 +0100
        +++ plugin.xml 2006-11-07 11:42:07.000000000 +0100
        @@ -121,6 +121,15 @@
        class="org.jayasoft.ivyde.eclipse.ui.actions.CreateContainerAction"
        enablesFor="1"
        />
        + </objectContribution>
        + <objectContribution
        + id="org.jayasoft.ivyde.eclipse.ui.actions.ResolveAllAction"
        + objectClass="org.eclipse.jdt.core.IJavaProject">
        + <action
        + class="org.jayasoft.ivyde.eclipse.ui.actions.ResolveAllAction"
        + enablesFor="*"
        + id="org.jayasoft.ivyde.eclipse.ui.actions.ResolveAllAction"
        + label="Resolve &all"/>
        </objectContribution>
        </extension>

        Show
        Thomas Friol added a comment - Unfortunately, I did not find the way to attach a file to this issue, so here is a patch to plug the action in the workbench : — plugin.xml.orig 2006-11-07 11:40:42.000000000 +0100 +++ plugin.xml 2006-11-07 11:42:07.000000000 +0100 @@ -121,6 +121,15 @@ class="org.jayasoft.ivyde.eclipse.ui.actions.CreateContainerAction" enablesFor="1" /> + </objectContribution> + <objectContribution + id="org.jayasoft.ivyde.eclipse.ui.actions.ResolveAllAction" + objectClass="org.eclipse.jdt.core.IJavaProject"> + <action + class="org.jayasoft.ivyde.eclipse.ui.actions.ResolveAllAction" + enablesFor="*" + id="org.jayasoft.ivyde.eclipse.ui.actions.ResolveAllAction" + label="Resolve &all"/> </objectContribution> </extension>
        Hide
        Thomas Friol added a comment -

        This patch is just to quickly plug the action but I think there is still some little work to do in order to improve this action.

        • It should be good to have only one progress window for all resolution
        • It should be good to have this action available anywhere in the workbench since it does not depends on the current selection.

        Any thoughts ?

        Show
        Thomas Friol added a comment - This patch is just to quickly plug the action but I think there is still some little work to do in order to improve this action. It should be good to have only one progress window for all resolution It should be good to have this action available anywhere in the workbench since it does not depends on the current selection. Any thoughts ?
        Hide
        Xavier Hanin added a comment -

        Sorry for the attachment problem, it seems that the jira configuration was changed, maybe when I moved to a new server. This should be fixed now.

        To activate the action there's already a contribution to the toolbar, but it's commented out in the file. The reason why it's commented is because I developed the feature quickly, and hadn't enough time to test it / check if user community was ok with it. But I'm glad to see you find it useful, and share your ideas about how to improve it, and I agree with your first point (I think the second is resolved when you use the commented code in the plugin.xml).

        Show
        Xavier Hanin added a comment - Sorry for the attachment problem, it seems that the jira configuration was changed, maybe when I moved to a new server. This should be fixed now. To activate the action there's already a contribution to the toolbar, but it's commented out in the file. The reason why it's commented is because I developed the feature quickly, and hadn't enough time to test it / check if user community was ok with it. But I'm glad to see you find it useful, and share your ideas about how to improve it, and I agree with your first point (I think the second is resolved when you use the commented code in the plugin.xml).
        Hide
        Thomas Friol added a comment -

        I did not see the comment part of the plugin.xml. So maybe the attached patch is better than the previous one.

        About the one progress window, I will try to provide quickly a patch.

        Another idea comes to my mind now : maybe it should be interesting to enable 'Resolve' and 'Refresh' actions on a selected Java project, no ?

        Show
        Thomas Friol added a comment - I did not see the comment part of the plugin.xml. So maybe the attached patch is better than the previous one. About the one progress window, I will try to provide quickly a patch. Another idea comes to my mind now : maybe it should be interesting to enable 'Resolve' and 'Refresh' actions on a selected Java project, no ?
        Hide
        Xavier Hanin added a comment -

        Great patch, thanks for your contribution

        Having resolve and refresh on the java project could be nice, in that case maybe it should be an 'Ivy' menu to avoid adding too much noise, especially if the project has no IvyDE classpath container. We should deal with that case and also with the case with several classpath containers.

        Another idea, with such an Ivy menu on the project we could had an entry to create a new ivy file for the project and automatically add it as a classpath container. But this is not directly related and thus would better go in another issue.

        Show
        Xavier Hanin added a comment - Great patch, thanks for your contribution Having resolve and refresh on the java project could be nice, in that case maybe it should be an 'Ivy' menu to avoid adding too much noise, especially if the project has no IvyDE classpath container. We should deal with that case and also with the case with several classpath containers. Another idea, with such an Ivy menu on the project we could had an entry to create a new ivy file for the project and automatically add it as a classpath container. But this is not directly related and thus would better go in another issue.
        Hide
        Thomas Friol added a comment -

        +1 for the Ivy Menu

        Show
        Thomas Friol added a comment - +1 for the Ivy Menu
        Hide
        Thomas Friol added a comment -

        Here is a patch for the single progress window.
        I know it is a really quick patch and there is still some improvments and less hacks to do but it works. Unfortunately I have not too much time to do better than this.
        I also hope that the provided patch is functionnal but all the necessary differences are present in the file.
        Maybe you would have much more time than me to improve this feature.

        Show
        Thomas Friol added a comment - Here is a patch for the single progress window. I know it is a really quick patch and there is still some improvments and less hacks to do but it works. Unfortunately I have not too much time to do better than this. I also hope that the provided patch is functionnal but all the necessary differences are present in the file. Maybe you would have much more time than me to improve this feature.
        Hide
        Xavier Hanin added a comment -

        The patch is ok for me, the only trouble is that it seems you changed the indentation of the ResolveAllAction class, so the patch shows that everything has changed.

        BTW, I won't have more time than you do to improve the feature, currently most of my open source dedicated time goes to Ivy and the move to ASF, but I'll integrate your patch later this week..

        Show
        Xavier Hanin added a comment - The patch is ok for me, the only trouble is that it seems you changed the indentation of the ResolveAllAction class, so the patch shows that everything has changed. BTW, I won't have more time than you do to improve the feature, currently most of my open source dedicated time goes to Ivy and the move to ASF, but I'll integrate your patch later this week..
        Hide
        Thomas Friol added a comment -

        Sorry for the ResolveAllAction class indentation. I tried to be careful about that but it seems I failed.

        BTW, thanks for your attention.

        Show
        Thomas Friol added a comment - Sorry for the ResolveAllAction class indentation. I tried to be careful about that but it seems I failed. BTW, thanks for your attention.
        Hide
        Xavier Hanin added a comment -

        I've finally integrated your patch, thanks again for your contribution! And sorry for the delay, you can thank your co worker Jean-Baptiste to have ping me about this issue

        Show
        Xavier Hanin added a comment - I've finally integrated your patch, thanks again for your contribution! And sorry for the delay, you can thank your co worker Jean-Baptiste to have ping me about this issue
        Hide
        Thomas Friol added a comment -

        So thanks Jean Baptiste, and thanks to you too Xavier. Thanks to Nicolas who pointed me to this resolved issue as it seems I did not receive any email.

        Show
        Thomas Friol added a comment - So thanks Jean Baptiste, and thanks to you too Xavier. Thanks to Nicolas who pointed me to this resolved issue as it seems I did not receive any email.

          People

          • Assignee:
            Xavier Hanin
            Reporter:
            Thomas Friol
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development