IvyDE
  1. IvyDE
  2. IVYDE-191

"Ivy Settings Path" Browse button results in an incorrectly formatted URL

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0.final
    • Fix Version/s: 2.1.0
    • Component/s: None
    • Labels:
      None

      Description

      "Ivy Settings Path" Browse button results in an incorrectly formatted URL string when you select a Windows network resource on the "Settings" preference page (e.g. file://istoolsrv1/Repository/ivy/ivysettings.xml when the correct URL is file:////istoolsrv1/Repository/ivy/ivysettings.xml). It is missing two forward slashes on the front of the URL.

        Activity

        Hide
        Jon Schneider added a comment -

        The text box was being set as follows:

        settingsText.setText(f.toURL().toExternalForm());

        toURL() is deprecated on File for J2SE 1.5 + anyway – changing to

        settingsText.setText(f.toURI().toURL().toExternalForm());

        fixes the issue. Patch for SettingsEditor attached.

        Show
        Jon Schneider added a comment - The text box was being set as follows: settingsText.setText(f.toURL().toExternalForm()); toURL() is deprecated on File for J2SE 1.5 + anyway – changing to settingsText.setText(f.toURI().toURL().toExternalForm()); fixes the issue. Patch for SettingsEditor attached.
        Hide
        Jon Schneider added a comment -

        Do I need to leave this in Open status for the patch to get picked up?

        Show
        Jon Schneider added a comment - Do I need to leave this in Open status for the patch to get picked up?
        Hide
        Nicolas Lalevée added a comment -

        Yep, this should stay open, resolved is when the patch is being integrated into the subversion.
        I will take care of this shortly.

        Show
        Nicolas Lalevée added a comment - Yep, this should stay open, resolved is when the patch is being integrated into the subversion. I will take care of this shortly.

          People

          • Assignee:
            Nicolas Lalevée
            Reporter:
            Jon Schneider
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development