IvyDE
  1. IvyDE
  2. IVYDE-188

Workspace Resolver Prevents Source Download

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0.beta1
    • Fix Version/s: 2.1.0
    • Component/s: workspace resolver
    • Labels:
      None
    • Environment:

      Ivy 2.0

      Description

      Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:

      ivy.getResolveEngine.download(....)

      This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.

      The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.

      1. IVYDE-188.patch
        3 kB
        Phillip Webb

        Issue Links

          Activity

          Hide
          Phillip Webb added a comment -

          Attached a patch

          Show
          Phillip Webb added a comment - Attached a patch
          Hide
          Phillip Webb added a comment -

          Removed the patch, the resolver cannot skip adding a download report.

          Show
          Phillip Webb added a comment - Removed the patch, the resolver cannot skip adding a download report.
          Hide
          Phillip Webb added a comment -

          Attached Patch

          Show
          Phillip Webb added a comment - Attached Patch
          Hide
          Phillip Webb added a comment -

          Using DownloadStatus.FAILED seems to fix the problem

          Show
          Phillip Webb added a comment - Using DownloadStatus.FAILED seems to fix the problem
          Hide
          Nicolas Lalevée added a comment -

          DownloadStatus.FAILED resolve the issue yes, thanks.
          But then it raised another one: the module descriptor of a project was declaring a default jar artifact which will then failed to be download (intead of no download).
          Both are now fixed in trunk.

          Show
          Nicolas Lalevée added a comment - DownloadStatus.FAILED resolve the issue yes, thanks. But then it raised another one: the module descriptor of a project was declaring a default jar artifact which will then failed to be download (intead of no download). Both are now fixed in trunk.

            People

            • Assignee:
              Nicolas Lalevée
              Reporter:
              Phillip Webb
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development