[IVY-885] Invalid URL when using dynamic ranges

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-beta-1
• Fix Version/s: 2.0-RC1
• Component/s: Core
• Assignee: Maarten Coene
• Reporter: Jim Bonanno
• Created: 21/Aug/08 12:15
• Updated: 04/Sep/08 17:52
• Resolved: 02/Sep/08 20:20

Description

Sorry to have two url issues in one day.

We are using ivy's ranges to resolve our modules. Ivy first tries to see if the specified version exists before listing the repository. The issue that we hit was when using the range [1,2[. The first request is http://myhost/my-repo/org/module/ivys/ivy-[1,2[.xml.

This URL is not properly escaped, but apache apparently is very forgiving. When we hosted the ivy repository with another web server that validated the urls the returned status code was not a 404.

We are working around the problem by again using URI to build the URL so it gets properly escaped. There seems to be some tricks to using the URI class. For example, the constructor that takes a string requires the string is already rfc 2396 compliant. The other constructors will actually escape the URL.

Here is the modifications we made to the BasicURLHandler.

if ( url.getProtocol().equals("http") || url.getProtocol().equals("https")) {
try

{ URI uri = new URI(url.getProtocol(), null, url.getHost(), url.getPort(), url.getPath(), null, null); url = uri.toURL(); }

catch ( URISyntaxException e )

{ IOException ioe = new IOException("Couldn't open connection to '" + url.toString() + "'"); ioe.initCause(e); throw ioe; }

}
con = url.openConnection();

which results in a request http://myhost/my-repo/org/module/ivys/ivy-%5B1,2%5B.xml.