Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-60

Vague error message due to coding style

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Component/s: Ant
    • Labels:
      None

      Description

      In most Ant tasks, a validity check is performed on bean properties and ant properties to check for null.
      Unfortunately everything is mixed in a hurry and the user does get a vague unhelpful message

      For example in IvyPublish:

      if (_module == null || _organisation == null || _revision == null)

      { throw new BuildException("empty or incomplete module revision id provided for publish: either call resolve, give paramaters to publish, or provide ivy.module, ivy.organisation and ivy.revision properties"); }

      Provide a useless indication to the user of what is actually wrong. is it module ? organisation ? revision ? why does the message mention a revision id ? what should I do to fix that ?

      Every required property should preferably be checked individually and send back a helpful message such as:

      "Missing module property. It can either be set explicitely via the attribute 'module' or via 'ivy.module' property or a prior call to <resolve/>". YMMV

        Attachments

          Activity

            People

            • Assignee:
              xavier Xavier Hanin
              Reporter:
              sbailliez Stephane Bailliez
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: